Permaban Script [HELP]

Cicciobello | 2012-03-24 19:29

I've made this script to ban a player with dynamic IP, but the script does nothing when it executes pl_banner: please help me finding my mistake because I really cannot

here's the script

//----BANNER-SCRIPT TO BAN----//
// INSTALL: write in the console '/showgui banner' and hit ENTER or remove // at the beginning of the next line (the menu will be bound to L)
//bind L [showgui banner]


//----VARIABLES----//
tagfind = "TAG"
createine iter = 0
isforever = 0
//xxxx//


//----FUNCTIONS----//
pl_banner = [
	iter = -1
	while [(= $isforever 1)] [
		iter = (+ $iter 1)
		sleep (+ (* 5 $iter) 5) [
			looplist cn (listclients 0) [ 
				if (= (strstr (getclientname $cn) $tagfind) -1) [
					//The player has not the tag we look for
				] [ 
					kick (getclientname $cn) 
				] 
			]
		]
	]
]
//xxxx//


//----GUI MENUS----//
newgui "banner" [
	guitext "Menu to permaban players with a "
	guitext "specific tag"
	guititle
	guicheckbox "Permaban (Check to use)" isforever [0 1 pl_banner]
	guilist [
		guitext "Tag to search"
		guifield tagfind
	]
	guibar
	guitext (format "^fPlayers with tag ^f3%1 ^f7are:" $tagfind)
	looplist cn (listclients 0) [
		if (= (strstr (getclientname $cn) $tagfind) -1) [] [
			guilist [
				guitext (concatword $cn " ^f3" (getclientname $cn) "^f7: ") (getclienticon $cn)
				guibutton "kick " (concat "kick" $cn)
				guibutton "spectator " (concat "spectator" (= (isspectator $cn) 0) $cn)
				guibutton "swap team" (concat "setteam" $cn (if (strcmp (getclientteam $cn) "good") [result "evil"] [result "good"]))
			]
		]
	]
]
//xxxx/

Rating

points

(0 votes)

Comments

RaZgRiZ | 2012-03-24 19:39

The way you have it, i figure while is happening so rapidly that your 'iter' variable becomes too large too fast, resulting in huge sleep amounts, making it appear as if it isn't working. I can fix that easily.

pl_banner = [
	sleep 100 [
		looplist cn (listclients) [ 
			if (> (strstr (getclientname $cn) $tagfind) -1) [
				kick $cn
			] 
		]
		pl_banner
	]
]

newgui "banner" [
	guitext "^f7Ban players with a specific tag" 0
	guititle
	guicheckbox "Repeated Ban" isforever 0 1 [pl_banner]
	guilist [
		guitext "^f7Tag to search" 0
		guifield tagfind
	]
	guibar
	guitext (format "^f7Players with tag ^f3%1 ^f7are:" $tagfind) 0
	looplist cn (listclients) [
		if (> (strstr (getclientname $cn) $tagfind) -1) [
			guilist [
				guitext (format "^f7%1 ^f3%2 ^f7: " $cn (getclientname $cn)) (getclienticon $cn)
				guibutton "kick " [kick" @cn] 0
				guibutton "spectator " [spectator (= (isspectator @cn) 0) @cn] 0
				guibutton "swap team" [setteam @cn (? (=s (getclientteam @cn) good) evil good)] 0
			]
		]
	]
]

A correction however.. your script does not ban someone with a dynamic IP. All it does is kick people whose name matches the tag search, which is extremely error prone as anyone with the search string in their name would be kicked out, him being someone unwanted or not.

EDIT: Took the liberty of updating your GUI and making it a bit more appropriate to look at. :P

srbs | 2012-03-24 21:55

Note: This is what is currently wrong with your script, after this is fixed, you will have the infinite loop issue that is solved by what Razgriz said above. Also, as Razgriz said this only kicks people with names containing the tag, it is not suggested to ever use this.

1. guicheckbox "Permaban (Check to use)" isforever [0 1 pl_banner]
2. while [(= $isforever 1)] [

Your arguments for guicheckbox is incorrect:
guicheckbox <name> <var> [<onvalue> [<offvalue> [<body>]]]

In your code (1):
name = "Permaban ..." var = forever onvalue = [0 1 pl_banner] offvalue = 0 //default body = "" //default

Because the onvalue is not a number (and starts with 0) the statement in (2) will always be false.

You would fix this by moving the [ to right before the pl_banner call:
guicheckbox "Permaban (Check to use)" isforever 0 1 [pl_banner]

User login

Navigation

Users on Quadropolis